Updates container image versions for external-dns and kubeip deployments #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you only have a single replica in a deployment, a rolling update doesn't always make the most sense, especially if the service isn't user facing. This change sets the update strategy for the kubeip deployment to a simple "Recreate", which will just delete the old pod and create a new one.
stephen-soltesz
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
Is there service interruption during this switch? if so, which services are impacted? e.g. monitoring to production services, etc..
configuration
Reviewed 3 of 3 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, the PR moves the kubeip deployment, and related resources, to the kube-system namespace, resolving this issue: #824
NOTE: Changing the namespace of the kubeip deployment and related resources requires recreating the GCP service account key Secret in the kube-system namespace:
... and also deleting the resources in the default namespace:
This change is