Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Semantic Version Checker Reusable Action #24

Merged

Conversation

lefte
Copy link
Contributor

@lefte lefte commented Nov 2, 2022

  • Created a reusable semantic version checker GitHub action using work from the main Magento repository

* Created a reusable semantic version checker GitHub action using work
  from the main Magento repository
@lefte lefte requested a review from a team as a code owner November 2, 2022 14:51
@lefte
Copy link
Contributor Author

lefte commented Nov 2, 2022

See mage-os/mageos-magento2#11 for the original request, this should be a reusable action that can be called on any other repository

* Correct workflow caller
* Add a self-check function
* Explain the help argument call (prevents Magento from being installed,
  which isn't needed for this check)
Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vinai Vinai merged commit 5a8eaec into mage-os:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants