Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5 GitHub Action Semantic Checker #11

Merged

Conversation

lefte
Copy link
Contributor

@lefte lefte commented Nov 1, 2022

GitHub Action Semantic Checker

Creates a GitHub Action to run the Semantic Version Checker against the head and base branches

Fixed Issues

Addresses issue #5

lefte added 14 commits October 31, 2022 14:16
* Check out the semver and local repo using GitHub action steps
* Use more GitHub Action helpers
* Correct repository name
* Move Composer caching and fix action versions
* Moved Composer to after the code checkout
* Fix checked-out code path
* Default to the 2.4-develop branch for comparison
* Save the SVC log output for future reference
* Install Composer before cache checks
* Fixed the environment variable naming change in GH Actions
* Fix the path variable outputting
* Rename back to the step name, not an environment variable
* Change the trigger to use pull requests only
* Switch to an expression for this use
@lefte lefte requested a review from a team as a code owner November 1, 2022 21:26
@lefte
Copy link
Contributor Author

lefte commented Nov 2, 2022

Working on repairing the forked repository variable on the broken step

lefte added 3 commits November 1, 2022 22:18
* Output some variables to test
* Additional environment debugging
* Use the correct GitHub event variable
@lefte
Copy link
Contributor Author

lefte commented Nov 2, 2022

Okay, thanks for your patience, action https://github.com/mage-os/mageos-magento2/actions/runs/3374600139 should now work with forked repositories.

Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this workflow only relevant for the mageos-magento2 repository?
I assume it will also be useful for the other mageos-* repos.
Because of this, I suggest making it a reusable workflow inside of https://github.com/mage-os/infrastructure, kind of like merge-upstream-changes.yml.
This helps with maintenance

.github/workflows/semantic-checker.yml Outdated Show resolved Hide resolved
@lefte
Copy link
Contributor Author

lefte commented Nov 2, 2022

Is this workflow only relevant for the mageos-magento2 repository? I assume it will also be useful for the other mageos-* repos. Because of this, I suggest making it a reusable workflow inside of https://github.com/mage-os/infrastructure, kind of like merge-upstream-changes.yml. This helps with maintenance

Yeah, I can start work on refactoring this to be a standalone action. Didn't think about using it for other repositories, although I think in theory we can just copy this file to other repos.. I'll find out.

lefte added 4 commits November 2, 2022 08:23
* Refactor to use the MageOS SVC mirror
* Make the branch comparisons more generic and re-usable
* Repaired the Composer cache variable
* Use the correct environment syntax
* Repaired the debug output JSON call
lefte added 2 commits November 2, 2022 09:57
* Moved this action to another repository
* Fire commit hook
@lefte
Copy link
Contributor Author

lefte commented Nov 2, 2022

Is this workflow only relevant for the mageos-magento2 repository? I assume it will also be useful for the other mageos-* repos. Because of this, I suggest making it a reusable workflow inside of https://github.com/mage-os/infrastructure, kind of like merge-upstream-changes.yml. This helps with maintenance

Yeah, I can start work on refactoring this to be a standalone action. Didn't think about using it for other repositories, although I think in theory we can just copy this file to other repos.. I'll find out.

Now refactored to reuse an action, although it has to be merged to the infrastructure repository before I can change it here

* Works against the mage-os/infrastructure reusable action now
@lefte
Copy link
Contributor Author

lefte commented Nov 23, 2022

(Waiting on mage-os/infrastructure#24 )

Copy link
Contributor

@Vinai Vinai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vinai Vinai merged commit d8f1ca2 into mage-os:2.4-develop Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants