-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5 GitHub Action Semantic Checker #11
Issue #5 GitHub Action Semantic Checker #11
Conversation
* Initial code push
* Check out the semver and local repo using GitHub action steps
* Use more GitHub Action helpers * Correct repository name
* Move Composer caching and fix action versions
* Moved Composer to after the code checkout
* Fix checked-out code path
* Default to the 2.4-develop branch for comparison
* Save the SVC log output for future reference
* Install Composer before cache checks
* Fixed the environment variable naming change in GH Actions
* Fix the path variable outputting
* Rename back to the step name, not an environment variable
* Change the trigger to use pull requests only
* Switch to an expression for this use
Working on repairing the forked repository variable on the broken step |
* Output some variables to test
* Additional environment debugging
* Use the correct GitHub event variable
Okay, thanks for your patience, action https://github.com/mage-os/mageos-magento2/actions/runs/3374600139 should now work with forked repositories. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this workflow only relevant for the mageos-magento2 repository?
I assume it will also be useful for the other mageos-* repos.
Because of this, I suggest making it a reusable workflow inside of https://github.com/mage-os/infrastructure, kind of like merge-upstream-changes.yml.
This helps with maintenance
Yeah, I can start work on refactoring this to be a standalone action. Didn't think about using it for other repositories, although I think in theory we can just copy this file to other repos.. I'll find out. |
* Refactor to use the MageOS SVC mirror * Make the branch comparisons more generic and re-usable
* Repaired the Composer cache variable
* Use the correct environment syntax
* Repaired the debug output JSON call
* Moved this action to another repository
* Fire commit hook
Now refactored to reuse an action, although it has to be merged to the infrastructure repository before I can change it here |
* Works against the mage-os/infrastructure reusable action now
(Waiting on mage-os/infrastructure#24 ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GitHub Action Semantic Checker
Creates a GitHub Action to run the Semantic Version Checker against the head and base branches
Fixed Issues
Addresses issue #5