Address review feedback

magnusbaeck · Mar 22, 2021 · 6891566 · 6891566
1 parent 2b78b2b
commit 6891566
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/Makefile b/Makefile
@@ -84,7 +84,7 @@ $(PROGRAM)$(EXEC_SUFFIX): gogenerate .FORCE $(GOVVV)
 	govvv build -o $@
 
 .PHONY: gogenerate
-generate: $(MOQ)
+gogenerate: $(MOQ)
 	go generate ./...
 
 .PHONY: check

diff --git a/internal/daemon/logstashconfig/file.go b/internal/daemon/logstashconfig/file.go
@@ -28,12 +28,7 @@ func (f File) Save(targetDir string) error {
 		return err
 	}
 
-	err = ioutil.WriteFile(path.Join(targetDir, f.Name), f.Body, 0600)
-	if err != nil {
-		return err
-	}
-
-	return nil
+	return ioutil.WriteFile(path.Join(targetDir, f.Name), f.Body, 0600)
 }
 
 func (f *File) parse() error {

diff --git a/internal/daemon/pipeline/pipeline.go b/internal/daemon/pipeline/pipeline.go
@@ -87,10 +87,6 @@ func (a Archive) Validate() error {
 	return nil
 }
 
-// func (a Archive) walk() {
-
-// }
-
 func (a Archive) Zip() ([]byte, error) {
 	buf := new(bytes.Buffer)
 	w := zip.NewWriter(buf)