Update generate_config.sh version checking for wider compatibility #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: replace `grep -oP` with `grep -oE` for broader compatibility The `-P` option (Perl-compatible regex) is not supported in all versions of `grep`, particularly the default BSD `grep` on macOS. This change replaces `-P` with `-E` (extended regex), which is more widely available and ensures compatibility across different environments. Tested on macOS and Linux.
|
You know that we do not support macOS right? |
|
This was the only line preventing it working on my Mac. Would be great if it could be included -- would diversify where the container can run -- even if unsupported. |
|
On which Linux did you tested this? |
|
I tested on CentOS, but I see it doesn't work on Ubuntu. A more universal approach would be this. This works on Ubuntu, MacOS, CentOS.
|
|
Yes your last approach works better it seems. Can you update your pr? |
Replaced version checking using free-form text. Instead, uses Docker’s built-in templating instead of parsing free-form text. This gives cross-platform consistency without dependency on particular versions of grep.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: replace
grep -oPwithgrep -oEfor broader compatibilityThe
-Poption (Perl-compatible regex) is not supported in all versions ofgrep, particularly the default BSDgrepon macOS. This change replaces-Pwith-E(extended regex), which is more widely available and ensures compatibility across different environments.Tested on macOS and Linux.
Contribution Guidelines
What does this PR include?
Short Description
This PR replaces
grep -oPwithgrep -oEto improve compatibility across different environments. The-Poption (Perl-compatible regex) is not supported in all versions ofgrep, particularly the default BSDgrepon macOS. The script fails in its current format on MacOS. Using-E(extended regex) ensures broader support while maintaining the intended functionality.Affected Containers
None (this is a script change, not a change to Docker containers).
Did you run tests?
What did you test?
Tested the updated command on both macOS and Linux to ensure it extracts the major version correctly.
What were the final results? (Expected, actual)
Expected: The command should return only the major version number from
docker --version.Actual: The command correctly returns the major version number on both macOS and Linux.