Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generate_config.sh version checking for wider compatibility #6270

Merged
merged 2 commits into from
Feb 11, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update generate_config.sh version checking for wider compatibility
fix: replace `grep -oP` with `grep -oE` for broader compatibility

The `-P` option (Perl-compatible regex) is not supported in all versions of `grep`, particularly the default BSD `grep` on macOS. This change replaces `-P` with `-E` (extended regex), which is more widely available and ensures compatibility across different environments.

Tested on macOS and Linux.
digitalhen authored Jan 28, 2025
commit f9ce3b37745b55f189a3411fff39d6ba97a34feb
2 changes: 1 addition & 1 deletion generate_config.sh
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ for bin in openssl curl docker git awk sha1sum grep cut; do
done

# Check Docker Version (need at least 24.X)
docker_version=$(docker -v | grep -oP '\d+\.\d+\.\d+' | head -n 1 | cut -d '.' -f 1)
docker_version=$(docker -v | grep -oE '\d+\.\d+\.\d+' | head -n 1 | cut -d '.' -f 1)

if [[ $docker_version -lt 24 ]]; then
echo -e "\e[31mCannot find Docker with a Version higher or equals 24.0.0\e[0m"