Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task done #1310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

UrbanAstronaut88
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code implementation is solid and meets the task requirements effectively! 🎉 The classes and functions are well-structured and fulfill the specified functionality. Just a small note: ensure that you import and use List from the typing module correctly in your type annotations. Keep up the great work and happy coding! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

@@ -1 +1,46 @@
# write your code here
from typing import List

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The List type from the typing module is imported but not used correctly in the feed_animals function. Ensure that List is used with a capital 'L' as it is imported from typing.

print("The slippers delivered!")


def feed_animals(animals: List[Animal]) -> int:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation List[Animal] is correct, but make sure that List is imported from the typing module as it is used here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants