Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task done #1310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion app/main.py
Original file line number Diff line number Diff line change
@@ -1 +1,46 @@
# write your code here
from typing import List

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The List type from the typing module is imported but not used correctly in the feed_animals function. Ensure that List is used with a capital 'L' as it is imported from typing.


class Animal:
def __init__(
self,
name: str,
appetite: int,
is_hungry: bool = True
) -> None:
self.name: str = name
self.appetite: int = appetite
self.is_hungry: bool = is_hungry

def print_name(self) -> None:
print(f"Hello, I'm {self.name}")

def feed(self) -> int:
if self.is_hungry:
print(f"Eating {self.appetite} food points...")
self.is_hungry = False
return self.appetite
return 0


class Cat(Animal):
def __init__(self, name: str, is_hungry: bool = True) -> None:
super().__init__(name, appetite=3, is_hungry=is_hungry)

def catch_mouse(self) -> None:
print("The hunt began!")


class Dog(Animal):
def __init__(self, name: str, is_hungry: bool = True) -> None:
super().__init__(name, appetite=7, is_hungry=is_hungry)

def bring_slippers(self) -> None:
print("The slippers delivered!")


def feed_animals(animals: List[Animal]) -> int:
total_food: int = 0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotation List[Animal] is correct, but make sure that List is imported from the typing module as it is used here.

for animal in animals:
total_food += animal.feed()
return total_food
Loading