Bump live_view to 1.0 #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Munksgaard
force-pushed
the
bump-liveview
branch
from
cbe548b to
ec963c1
Compare
LiveView 1.0 adds support for interpolation using curly braces (`{...}`) instead
of angle brackets (`<%= ... %>`)[0]. This caused a compilation error in
`ShowcaseLive`, because we return literal curly braces in the HTML. The fix is to
either use `{` or `<%= "{" %>`[1]. I think the former is nicer, so that's
what I've done here. If you disagree, I'm happy to change it.
I've also changed some instances of `live_flash/2` to `Phoenix.Flash.get/2`, as
`live_flash/2` is now deprecated[2]
Fixes: maxmarcon#88
0: https://hexdocs.pm/phoenix_live_view/Phoenix.Component.html#sigil_H/2-interpolation
1: phoenixframework/phoenix_live_view#3554
2: https://hexdocs.pm/phoenix_live_view/changelog.html#deprecations-1
Munksgaard
force-pushed
the
bump-liveview
branch
from
ec963c1 to
129f7bd
Compare
|
It seems like liveview 1.0 requires elixir 1.14.1. In particular, the error that CI is reporting is that this macro doesn't exist, and it was added in 1.14.1. What do you want to do @maxmarcon? |
|
Thanks for the PR, I noticed only now. Sorry about that... I just added support for LV 1.0.0 and published a new version |
|
No worries, thanks for the release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiveView 1.0 adds support for interpolation using curly braces (
{...}) instead of angle brackets (<%= ... %>)[0]. This caused a compilation error inShowcaseLive, because we return literal curly braces in the HTML. The fix is to either use{or<%= "{" %>[1]. I think the former is nicer, so that's what I've done here. If you disagree, I'm happy to change it.I've also changed some instances of
live_flash/2toPhoenix.Flash.get/2, aslive_flash/2is now deprecated[2]Fixes: #88
0: https://hexdocs.pm/phoenix_live_view/Phoenix.Component.html#sigil_H/2-interpolation
1: phoenixframework/phoenix_live_view#3554
2: https://hexdocs.pm/phoenix_live_view/changelog.html#deprecations-1