Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The language negotiator will convert the locale names into canonical … #507

Merged
merged 1 commit into from
Nov 11, 2017

Conversation

ansata2001
Copy link
Contributor

Improved languageNegotiator, the en-US will match en_US and vice-versa, using the intl extension which has been added to "suggests" of the composer.json.

@mcamara mcamara merged commit e984285 into mcamara:master Nov 11, 2017
@mcamara
Copy link
Owner

mcamara commented Nov 11, 2017

Thanks for your commit!

@erdmenchen
Copy link

Does this also fix #505 ?

@ansata2001
Copy link
Contributor Author

@erdmenchen I don't think so

@ansata2001 ansata2001 deleted the updated-language-negotiation branch March 28, 2018 20:39
@marlongichie
Copy link

Was this fix removed? And if so, is there another solution to get this to work properly?

I'm using "mcamara/laravel-localization": "^1.3" and en-US does NOT match en_US as discussed here.

@ansata2001
Copy link
Contributor Author

@marlongichie No it wasn't removed. Do you have the intl extension installed and enabled?

@marlongichie
Copy link

I've been testing using the vagrant homestead box. I believe the intl extension comes installed and active out of the box.

So far NOT able to get this feature to work.

Doesn't seem like this should be so complex to get working and would probably be more Laravel like to implement it off the shelf with this package, without needing to modify the environment, no???

Any suggestions or workarounds?

@ansata2001
Copy link
Contributor Author

Not sure if intl is installed by default, I think it's not. And it's not hard to install it and activate.

If you're not up to the intl solution - feel free to implement it the way you like. Laravel is not like to obviously.

Suggestion - check if the intl is up and running. php -i | grep intl from the command line from within the vagrant box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants