-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data for HTMLSelectElement showPicker #20852
Conversation
0471ade
to
7519753
Compare
I noticed this was marked as a draft, but this looks ready to go? |
@queengooborg I was waiting till the spec PR got merged. Currently the spec link won't work. Happy to unmark as draft if you think that's fine |
Ah, thanks for pointing that out! If you'd like, we can mark this as non-standard for now, and then follow up with another PR to add the spec URL when it becomes standard; or, we can leave this unmerged until the spec changes are official. I have no preference either way! |
@queengooborg the spec PR just got merged so this is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Firefox bug is marked as fixed in 121. https://bugzilla.mozilla.org/show_bug.cgi?id=1854112 and the Chromestatus says shipping in 121.
Can you update this PR?
79d1552
to
a5cdc72
Compare
Added Firefox flagged support and marked as stable in chrome from 121 (here's the PR to flip it on waiting for review https://chromium-review.googlesource.com/c/chromium/src/+/5034127) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 👍
a5cdc72
to
754f621
Compare
(sorry last minute change realised it's also out in Safari Tech Preview) |
}, | ||
"chrome_android": "mirror", | ||
"edge": "mirror", | ||
"firefox": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI only the bug now says this is enabled in "nightly" so have updated this to preview
in #21280
Summary
Add data for HTMLSelectElement showPicker
Test results and supporting details
Pull request for html spec: whatwg/html#9754
Chrome Status Entry: https://chromestatus.com/feature/5111537299881984
Content PR: mdn/content#29406
Related issues