Add page for HTMLSelectElement showPicker() #29406
Conversation
|
Preview URLs
Flaws (12)Note! 3 documents with no flaws that don't need to be listed. 🎉 URL:
(comment last updated: 2023-12-08 00:46:30) |
|
The Browser Compat Data PR has been merged. |
| // showPicker() is supported. | ||
| } | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Could we have an example of this being used? I'm thinking simple code like in the explainer:
<select id="select">
<option>Item 1</option>
<option>Item 2</option>
</select>
<button onclick="select.showPicker()">Show the select option picker</button>
Then we can explain WHY you don't just have the normal form submit or whatever here - i.e. why is this needed/useful.
There was a problem hiding this comment.
@lukewarlow I'll leave this to you and rereview when you ping me!
There was a problem hiding this comment.
Yep no worries! I'm out of office this week so it'll be next week but I'll make the requested changes to get this landed.
There was a problem hiding this comment.
Excellent. I'm off after today until Friday week, so will review your changes then.
There was a problem hiding this comment.
Thanks for this. Looks great. A few questions/ comments such as https://github.com/mdn/content/pull/29406/files#r1398576219
lukewarlow
force-pushed
the
select-showpicker
branch
from
a116c12 to
14635e0
Compare
|
@hamishwillee I've added that example. Haven't added a "use case" atm, not sure how best to word it potentially can be done as a follow up? |
hamishwillee
force-pushed
the
select-showpicker
branch
from
14635e0 to
c1fec39
Compare
There was a problem hiding this comment.
Thanks @lukewarlow
- I see use case information as helpful but not mandatory.
- I've made a few subedit changes:
- Headings are sentence case
- "Usage" is probably OK here, but usually examples have specific titles about what they cover.
- I hid the comment about live examples. It is useful if someone else comes along to edit this and decides to add the live example, but there is no expectation for readers.
- I cross linked to the transient activation page and the input version of the method.
- If you have any other questions about what I did feel free to ask.
This is good. Thanks so much for sorting it out.
* Add page for HTMLSelectElement showPicker() * Minor subedit * Update files/en-us/web/api/htmlselectelement/showpicker/index.md * Update files/en-us/web/api/htmlselectelement/showpicker/index.md * Add usage example code * Subedit and cross link --------- Co-authored-by: Hamish Willee <[email protected]>
Description
Add page for HTMLSelectElement showPicker()
Motivation
Added as a requirement of the HTML PR.
Additional details
HTML Spec PR: whatwg/html#9754
ChromeStatus Entry: https://chromestatus.com/feature/5111537299881984
Related issues and pull requests
Browser Compat Data PR: mdn/browser-compat-data#20852
EDIT - HamishW: Docs team tracking Issue: #30336