OZ-502: GA workflows to use shared workflow to allow image releases. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.github/workflows/build.yml
Outdated
| download-artifacts: false | ||
| image-name: "senaite" | ||
| secrets: | ||
| DOCKER_HUB_USERNAME: mekomsolutions |
There was a problem hiding this comment.
Let's use username from secrets here.
There was a problem hiding this comment.
I am not sure we have one. We will need @rbuisson to confirm
There was a problem hiding this comment.
Those are the secrets vars available at the org level
.github/workflows/build.yml
Outdated
Comment on lines
6
to
7
| pull_request: | ||
| branches: [main] |
There was a problem hiding this comment.
Remove on pull_request. We don't want to build and publish docker images on PR
mks-d
changed the title
|
This looks ok, however we need to modify here to not fail when it is not a maven project and also accepts "tags" as input variable which should defaults to empty. This means in additional to |
corneliouzbett
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GA workflow to use the shared workflow to allow us to release the image. See https://mekomsolutions.atlassian.net/browse/OZ-502