Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OZ-502: GA workflows to use shared workflow to allow image releases. #13

Merged
merged 4 commits into from
May 22, 2024
Merged

OZ-502: GA workflows to use shared workflow to allow image releases. #13

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17b85e7
OZ-502: Update GH workflows to allow us to release
enyachoke May 20, 2024
3f71354
Remove on pull
enyachoke May 20, 2024
b433510
Set DOCKER_HUB_USERNAME from secret
enyachoke May 21, 2024
1adca81
Tag image with Dev to test workflow
enyachoke May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 13 additions & 47 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,52 +2,18 @@ name: CI

on:
push:
branches: [ main ]
workflow_dispatch:
branches: [main]
pull_request:
branches: [main]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove on pull_request. We don't want to build and publish docker images on PR

release:
types: [published]

jobs:
build:
runs-on: ubuntu-latest
steps:
-
name: Checkout
uses: actions/checkout@v2
-
name: Set up QEMU
uses: docker/setup-qemu-action@v1
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v1
-
name: Login to DockerHub
if: github.ref == 'refs/heads/main'
uses: docker/login-action@v2
with:
username: mekomsolutions
password: ${{ secrets.DOCKER_HUB_REGISTRY_PASSWORD }}
-
name: Docker meta
id: meta
uses: docker/metadata-action@v4

with:
images: |
mekomsolutions/senaite
tags: |
type=raw,value=latest,enable={{is_default_branch}}
type=pep440,pattern={{version}}
type=pep440,pattern={{major}}.{{minor}}
type=sha
-
name: Get commit id
id: vars
run: echo "::set-output name=sha_short::$(git rev-parse --short HEAD)"
-
name: Build and push
uses: docker/build-push-action@v2
env:
SERVICE: senaite
with:
platforms: linux/amd64,linux/arm64
push: true
tags: ${{ steps.meta.outputs.tags }}
docker-release:
uses: mekomsolutions/shared-github-workflow/.github/workflows/docker-build-publish.yml@main
with:
download-artifacts: false
image-name: "senaite"
secrets:
DOCKER_HUB_USERNAME: mekomsolutions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use username from secrets here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we have one. We will need @rbuisson to confirm

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are the secrets vars available at the org level

Screenshot 2024-05-21 at 14 13 35

DOCKER_HUB_PASSWORD: ${{ secrets.DOCKER_HUB_REGISTRY_PASSWORD }}
Loading