API improvements #30
Merged
API improvements #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noarkhh
requested changes
Aug 28, 2024
lib/boombox/mp4.ex
Outdated
| @@ -77,4 +77,24 @@ defmodule Boombox.MP4 do | |||
|
|
|||
| %Ready{actions: [spec: spec]} | |||
| end | |||
|
|
|||
| defp resolve_transport(location, opts) do | |||
There was a problem hiding this comment.
I think a function resolving the transport would be better to have in Boombox.Pipeline, since the transport option won't be unique to mp4 files (for example we'll support streaming HLS to a server).
|
|
||
| @spec get_switch_type([String.t()], atom(), Keyword.t()) :: :boolean | :string | ||
| defp get_switch_type(argv, option, aliases) do | ||
| with [] <- OptionParser.parse(argv, strict: [{option, :string}], aliases: aliases) |> elem(0), |
There was a problem hiding this comment.
pretty esoteric use of with, I like it :P
Noarkhh
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.