Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build using Watcom #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix build using Watcom #192

wants to merge 1 commit into from

Conversation

sezero
Copy link
Contributor

@sezero sezero commented Mar 20, 2021

No description provided.

@sezero
Copy link
Contributor Author

sezero commented Mar 30, 2021

PING?

@oehhar
Copy link
Contributor

oehhar commented Mar 31, 2021

Dear sezero,
THank you for your contribution. This is appreciated.

AFAIK only bugfixes are accepted to nanosvg. I suppose you should clearly state why your proposed change is a bugfix, as this is not obvious (for me).

And it would not harm to be a bit friendly.

Thank you again,
Harald

@oehhar
Copy link
Contributor

oehhar commented Mar 31, 2021

Don't take it from the wrong side. I would love to have this change in, as I also use a non C99 compatible compiler (MS-VC6).
But this is not in the scope of the project.

Thank you,
Harald

@sezero
Copy link
Contributor Author

sezero commented Mar 31, 2021

This is for making nanosvg to compile using OpenWatcom:
It doesn't accept non-const array initializers or declarations
after statements.

If this is not acceptable, feel free to close this.

@sezero
Copy link
Contributor Author

sezero commented Mar 31, 2021

And it would not harm to be a bit friendly.

I wasn't aware that I was unfriendly.

@oehhar
Copy link
Contributor

oehhar commented Mar 31, 2021

Ozkan,
sorry, I am not the maintainer. I just try to help to get this in. So explaining why you want that would help.
Thats all.

And beeing friendly is on the level, that the programmer gave this gem for free and probably has invested monthes of his spare time. So starting with "thank you for the great software" would eventually be appropriate.

Thank you,
Harald

@sezero
Copy link
Contributor Author

sezero commented Jun 6, 2021

PING?

@sezero
Copy link
Contributor Author

sezero commented May 25, 2022

PING? This is just a trivial C89-compatibility patch..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants