Update eXOF proposal with EUROCXOF rateFeed #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissnad
reviewed
Sep 10, 2023
| rateFeedConfig.valueDeltaBreaker0 = Config.ValueDeltaBreaker({ | ||
| enabled: true, | ||
| threshold: FixidityLib.newFixedFraction(5, 1000), // 0.005 |
There was a problem hiding this comment.
Removing this value breaker on EURXOF has two consequences:
- Only one of the base pairs that build EUROC/XOF has a tight (50bps) value breaker
- The CELO/eXOF pool will only inherit the 10% value breaker. In particular, CELO/eXOF will stay active while EUROC/eXOF is suspended until it auto-recovers.
I think we could live with 1, by maybe lowering EUROC/XOF value breaker threshold to 50bps.
But 2 does not feel great. Allowing minting / redemption through CELO/eXOF while we do not via EUROC
nvtaveras
reviewed
Sep 15, 2023
added 6 commits
September 15, 2023 12:14
sissnad
reviewed
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We decided to differentiate between EURXOF (pure exchange rate) and EUROCXOF (EUROC->EUR->XOF) rate which takes into account the EUROCEUR rate as well, and use the latter as the referace rate for the
eXOF/axlEUROCpool.This allows us to configure everything using a single ValueDeltaBreaker, so we can remove the nonrecoverable one, as the current one on mainnet has defaultCooldown = 0 as well.
Other changes
eXOFRevert.solwhich was used to revert the previously passed proposal. This will be updated to reflect the current proposal after it's passed on baklava.yarn cgpscript to support-rfor revert.Tested
Not fully tested as there are no oracle reports on baklava for EUROCEUR.
Related issues
Fixes https://github.com/mento-protocol/mento-general/issues/313
Backwards compatibility
N/A
Documentation
N/A