Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eXOF proposal with EUROCXOF rateFeed #127
Update eXOF proposal with EUROCXOF rateFeed #127
Changes from 9 commits
6372f05
00abbc2
2d43329
a2e8e97
b913055
d82d020
c3d15b7
e90449a
11c9214
1b42636
9e81528
8f5ccb3
adaa57a
3a7d717
4059a6b
445a622
1901b71
06eb619
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Check warning on line 74 in script/upgrades/eXOF/Config.sol
GitHub Actions / Lint & Build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this value breaker on EURXOF has two consequences:
I think we could live with 1, by maybe lowering EUROC/XOF value breaker threshold to 50bps.
But 2 does not feel great. Allowing minting / redemption through CELO/eXOF while we do not via EUROC
Check warning on line 87 in script/upgrades/eXOF/Config.sol
GitHub Actions / Lint & Build
This file was deleted.