Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support M5 core2、corebasic2.7+Module-LoRa433_V1.1+GNSS Module #4471

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

weekroom
Copy link

I am developing with M5 Core Basic V2.7 as the host, along with the LoRa Module (Module-LORA433_V1.1) and the GPS Module (GNSS Module), in a stacked design for ease of use. Interface Added the interface display of LORA-related data。

64b08c38b1eb15085121958d6381a2b
228e27124e6fca9d7cfdb95f4301fbd
e392066250fde51be4e8cc637a67c5a

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2024

CLA assistant check
All committers have signed the CLA.

@GPSFan
Copy link
Contributor

GPSFan commented Aug 16, 2024

The M9N is not specifically supported, but should work. There are some fiddly bits in the VALSET/VALGET config that could use some work. It's on the list... The M9N is an expensive solution that could be better addressed with an M10 or F10 device. But I guess that was not your choice, but M5Stacks.

@weekroom
Copy link
Author

@GPSFan Indeed, at present, I am making adaptation for the convenience of users, and I am also trying to use the gps atgm336h series to replace it

@armisis
Copy link

armisis commented Aug 16, 2024 via email

@weekroom
Copy link
Author

@armisis This one is to start the sound prompt, and then start to load the interface, not restart, maybe you can look at the log

@armisis
Copy link

armisis commented Aug 16, 2024 via email

@weekroom
Copy link
Author

@armisis You can annotate this macro definition #define PIN_BUZZER 25 in the variant.h file, and annotate M5.Speaker.tone, so that the buzzer will not start. Still working on it。For core2, I have been adapting, and for cores3, I have found that there is spi conflict between lora and lcd, which is still being solved

@armisis
Copy link

armisis commented Aug 16, 2024 via email

@weekroom weekroom changed the title Support M5 corebasic2.7+Module-LoRa433_V1.1+GNSS Module Support M5 core2、corebasic2.7+Module-LoRa433_V1.1+GNSS Module Aug 26, 2024
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, please see inline remarks.

src/ButtonThread.cpp Outdated Show resolved Hide resolved
src/graphics/Screen.cpp Show resolved Hide resolved
src/graphics/Screen.cpp Show resolved Hide resolved
src/graphics/Screen.cpp Show resolved Hide resolved
src/main.cpp Show resolved Hide resolved
src/mesh/RadioInterface.cpp Show resolved Hide resolved
src/mesh/generated/meshtastic/mesh.pb.h Show resolved Hide resolved
Copy link
Member

@caveman99 caveman99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking fine now.

@caveman99
Copy link
Member

Please run trunk fmt on the code (this won't work on windows!) or enable maintainer edits for your fork, so we can tidy it up before merging.

@weekroom
Copy link
Author

weekroom commented Sep 3, 2024

@caveman99 Hello, at present I am on Windows, can compile and burn normally, may I ask you what is the problem
60d4b6ce889d7d438519fd2cad18046
772c7d58657c242d2613c437d5a34c8

@fifieldt
Copy link
Contributor

@weekroom , trunk refers to: https://docs.trunk.io/code-quality - it's a code linter.

@lboue
Copy link
Contributor

lboue commented Sep 23, 2024

@weekroom
There are instructions on this page on how to install on a Windows environment:
https://docs.trunk.io/code-quality/setup-and-installation/initialize-trunk

Alternatively, you can use GitPod: https://gitpod.io#https://github.com/m5stack/meshtastic-firmware
image

@weekroom
Copy link
Author

@fifieldt @lboue Thanks for your help, I'm going to learn about using trunk

@prusnak prusnak mentioned this pull request Sep 30, 2024
2 tasks
@lboue
Copy link
Contributor

lboue commented Oct 1, 2024

@fifieldt @lboue Thanks for your help, I'm going to learn about using trunk

Did you succeed?

@lboue
Copy link
Contributor

lboue commented Oct 10, 2024

@weekroom Do you have a problem with trunk?

@caveman99 caveman99 added the question Further information is requested label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants