Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 E2E: Remove ensure_kind.sh script #2277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 E2E: Remove ensure_kind.sh script #2277

wants to merge 1 commit into from
+0 −37

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Mar 3, 2025

What this PR does / why we need it:

We are using the kind module directly in the test suite, so there is no need to install kind directly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot metal3-io-bot requested review from honza and zaneb March 3, 2025 13:06
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lentzi90. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2025
@lentzi90 lentzi90 changed the title 🌱 E2E: Don't install kind 🌱 E2E: Remove ensure_kind.sh script Mar 3, 2025
@lentzi90 lentzi90 mentioned this pull request Mar 3, 2025
Open
tuminoid
tuminoid reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025
@tuminoid
Copy link
Member

tuminoid commented Mar 3, 2025

/cherry-pick release-0.9

@metal3-io-bot
Copy link
Contributor

@tuminoid: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90
E2E: Don't install kind
8397d35 
We are using the kind module directly in the test suite, so there is no
need to install kind directly.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-cleanup branch from 87a9f20 to 8397d35 Compare March 4, 2025 06:32
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
@lentzi90
Copy link
Member Author

lentzi90 commented Mar 4, 2025

I had forgotten to remove kind delete cluster from the cleanup script.

tuminoid
tuminoid reviewed Mar 4, 2025
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Cluster is deleted in the e2e test suite code now.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@honza honza Awaiting requested review from honza

@zaneb zaneb Awaiting requested review from zaneb

Assignees
No one assigned
Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lentzi90 @metal3-io-bot @tuminoid