-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Remove IPAM manifests related links and check in release process #2355
📖 Remove IPAM manifests related links and check in release process #2355
Conversation
Signed-off-by: peppi-lotta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/retitle 📖 Remove IPAM manifests related links and check in release process
Since the code isn't called since previous PR, this is more of doc change and cleanup than code change, retitleing.
@@ -620,32 +620,6 @@ verify_module_releases() | |||
echo -e "Done\n" | |||
} | |||
|
|||
verify_ipam_manifests() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, this isn't called anymore since your previous PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! Just cleaning out the script as it is no longer used.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
@tuminoid: Overrode contexts on behalf of tuminoid: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
What this PR does / why we need it: Due to changes in the day IPAM is deployed manifests were deleted. Logic and links to these manifest have become obsolete.