Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Remove IPAM manifests related links and check in release process #2355

Merged
merged 1 commit into from
Feb 27, 2025
Merged

📖 Remove IPAM manifests related links and check in release process #2355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs/releasing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,7 @@ Things you should check before making a release:
- Verify BMO's `apis` and `pkg/hardwareutils` dependencies are the latest. Prior
art:
[#1163](https://github.com/metal3-io/cluster-api-provider-metal3/pull/1163)
- Uplift IPAM `api` dependency,
[container image version](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/config/ipam/image_patch.yaml)
, and
[manifest resource](https://github.com/metal3-io/cluster-api-provider-metal3/blob/main/config/ipam/kustomization.yaml)
- Uplift IPAM `api` dependency
. Prior art:
[#999](https://github.com/metal3-io/cluster-api-provider-metal3/pull/999)
- Verify any other direct or indirect dependency is uplifted to close any
Expand Down
26 changes: 0 additions & 26 deletions hack/verify-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,32 +620,6 @@ verify_module_releases()
echo -e "Done\n"
}

verify_ipam_manifests()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this isn't called anymore since your previous PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! Just cleaning out the script as it is no longer used.

{
# verify version in ipam manifests match the ipam module version
# NOTE: this is CAPM3 specific check
local ipam_version

echo "Verifying IPAM manifests match go.mod ..."

# shellcheck disable=SC2311
ipam_version="$(_module_get_version "ip-address-manager/api")"

declare -A ipam_manifests=(
[config/ipam/image_patch.yaml]="quay.io/metal3-io/ip-address-manager:${ipam_version}"
[config/ipam/kustomization.yaml]="https://github.com/metal3-io/ip-address-manager/releases/download/${ipam_version}/ipam-components.yaml"
)

for file in "${!ipam_manifests[@]}"; do
str="${ipam_manifests[${file}]}"
if ! grep -q -- "${str}" "${file}"; then
echo "ERROR: IPAM version in go.mod and manifests mismatch!"
fi
done

echo -e "Done\n"
}

verify_vulnerabilities()
{
# run osv-scanner to verify if we have open vulnerabilities in deps
Expand Down
Loading