PvSTATEM 0.1.0 #193
Merged
PvSTATEM 0.1.0 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove extraneous column from RAU output * Limit the amount of dataframe presented in the vignettes
* Change warnings to message for handle_datetime * Fix warnings with bottom asymptote for plots * Manually handle values outside the asymptotes * Add test covering the warning
* inital draft of notes * implement additional notes in template * implement in package code * tests and multiline support * improved docs and new test * typos fix * docs rerun
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
==========================================
+ Coverage 87.51% 88.06% +0.54%
==========================================
Files 14 14
Lines 1650 1717 +67
==========================================
+ Hits 1444 1512 +68
+ Misses 206 205 -1 ☔ View full report in Codecov by Sentry. |
* remove warnings from report and decrease dpi of thumbnails -1.5MB * reduce size by 50% * add dependency and rerun docs * reports vignettes init * text without images yet * improve vignettes but still with no photo * clean report vignette * upload pictures * correctly add photos * better handling of images and new notes photo * fixing grammar
* adjusted file saving options to the style * added a bit more description of the plate name * added `normalised_data` dir to .gitignore * helper function for validation the filepaths * updated vignettes and docs * updated the docs * fixed minor errors * adjusted tests * tests for `validate_filepath_and_output_dir` * raise the package version * examples fix * Update R/generate_report.R Co-authored-by: Jakub Grzywaczewski <[email protected]> * added proposed changes from both the reviews * added proposed changes from both the reviews Update R/generate_report.R Co-authored-by: Jakub Grzywaczewski <[email protected]># This is a combination of 2 commits. added proposed changes from both the reviews Update R/generate_report.R Co-authored-by: Jakub Grzywaczewski <[email protected]> * `tmp_dir` -> `example_dir`; fixed some descriptions in vignettes --------- Co-authored-by: Fersoil <Fersoil> Co-authored-by: Jakub Grzywaczewski <[email protected]>
nizwant
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate_plate_reportandprocess_plategenerate_plate_reportfunction