Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calling store.UpdateFeed and store.UpdateFeedError in a defer function #2222

Closed
wants to merge 2 commits into from

Conversation

shizunge
Copy link
Contributor

@shizunge shizunge commented Nov 29, 2023

To calculate and to commit next check at in a single place.

Want to do this cleanup before working on #412

Do you follow the guidelines?

@shizunge
Copy link
Contributor Author

@shizunge shizunge marked this pull request as draft November 29, 2023 04:44
@shizunge shizunge force-pushed the defer-calling-schedule branch 2 times, most recently from bfa53fe to 4e8b8e6 Compare December 1, 2023 05:28
@shizunge shizunge force-pushed the defer-calling-schedule branch from 4e8b8e6 to 22b131f Compare December 1, 2023 23:17
@shizunge shizunge marked this pull request as ready for review December 1, 2023 23:18
@shizunge shizunge force-pushed the defer-calling-schedule branch from 22b131f to 5b83e53 Compare December 4, 2023 00:54
@shizunge
Copy link
Contributor Author

shizunge commented Dec 4, 2023

rebased

@shizunge shizunge force-pushed the defer-calling-schedule branch from 5b83e53 to a951837 Compare December 10, 2023 01:18
@shizunge shizunge force-pushed the defer-calling-schedule branch from a951837 to cc9573b Compare December 19, 2023 05:18
@shizunge shizunge force-pushed the defer-calling-schedule branch from cc9573b to ac91be5 Compare January 4, 2024 06:31
@shizunge shizunge force-pushed the defer-calling-schedule branch from ac91be5 to 735b0a0 Compare January 20, 2024 09:43
@shizunge shizunge force-pushed the defer-calling-schedule branch 2 times, most recently from 98b6558 to 7ba7382 Compare February 11, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant