Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lake_hylia.logic #89

Open
wants to merge 23 commits into
base: modules
Choose a base branch
from
Open

Update lake_hylia.logic #89

wants to merge 23 commits into from

Conversation

CandyCrystal
Copy link
Contributor

@CandyCrystal CandyCrystal commented Apr 1, 2021 •
edited
Loading

fixed #18

Ibot02
Ibot02 requested changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@Ibot02 Ibot02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs the splitting of the minish stuff with a pseudo-item that we talked about in the discord

lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
Ibot02
Ibot02 reviewed Apr 2, 2021
View reviewed changes
lake_hylia.logic Outdated Show resolved Hide resolved
Ibot02
Ibot02 reviewed Apr 2, 2021
View reviewed changes
lake_hylia.logic Outdated Show resolved Hide resolved
Ibot02
Ibot02 requested changes Apr 9, 2021
View reviewed changes
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
@Ibot02
Copy link
Contributor

Ibot02 commented Apr 9, 2021

This is missing the underwater and north Heart Pieces, I think?

@CandyCrystal
Copy link
Contributor Author

CandyCrystal commented Apr 9, 2021 •
edited
Loading

This is missing the underwater and north Heart Pieces, I think?

No, they are under NorthHP and FifiWaterHole!

@Ibot02
Copy link
Contributor

Ibot02 commented Apr 9, 2021

No, they are under NorthHP and FifiWaterHole!

Ah. They need to be chests, not items (that's why I didn't see them with a Ctrl+F)

@CandyCrystal
Copy link
Contributor Author

No, they are under NorthHP and FifiWaterHole!

Ah. They need to be chests, not items (that's why I didn't see them with a Ctrl+F)

OH! yes i will change that!

Ibot02
Ibot02 reviewed Apr 9, 2021
View reviewed changes
lake_hylia.logic Outdated Show resolved Hide resolved
Ibot02
Ibot02 requested changes Apr 9, 2021
View reviewed changes
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
lake_hylia.logic Outdated Show resolved Hide resolved
Ibot02
Ibot02 requested changes Apr 25, 2021
View reviewed changes
lake_hylia.logic Outdated Show resolved Hide resolved
CandyCrystal and others added 17 commits October 15, 2023 16:13
@CandyCrystal
Update lake_hylia.logic
9c78ec9
@CandyCrystal @Ibot02
Update lake_hylia.logic
8862bb1 
Co-authored-by: Ibot02 <[email protected]>
@CandyCrystal
Update lake_hylia.logic
bf7dd61
@CandyCrystal
Update lake_hylia.logic
4153843
@CandyCrystal
Update lake_hylia.logic
f721faa
@CandyCrystal
Update lake_hylia.logic
a091818
@CandyCrystal @Ibot02
Apply suggestions from code review
6593383 
Co-authored-by: Ibot02 <[email protected]>
@CandyCrystal
Update lake_hylia.logic
b204b60
@CandyCrystal
fix crest entrances/exits
677757f
@CandyCrystal
Update lake_hylia.logic
e529329
@CandyCrystal
Update lake_hylia.logic
d3f6862
@CandyCrystal
Update lake_hylia.logic
086f020
@CandyCrystal @Ibot02
Update lake_hylia.logic
4cac043 
Co-authored-by: Ibot02 <[email protected]>
@CandyCrystal @Ibot02
Apply suggestions from code review
25775f8 
Co-authored-by: Ibot02 <[email protected]>
@CandyCrystal
Update lake_hylia.logic
979ea93 
Added some missing enemies
@CandyCrystal
Update lake_hylia.logic
edc1b5f
@CandyCrystal @Ibot02
Update lake_hylia.logic
f16e0b9 
Co-authored-by: Ibot02 <[email protected]>
@CandyCrystal CandyCrystal changed the base branch from master to modules October 15, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ibot02 Ibot02 Ibot02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lake Hylia
2 participants
@CandyCrystal @Ibot02