Correcting README typos #1869
Merged
Correcting README typos #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rysc3
commented
Oct 6, 2024
| @@ -29,7 +29,7 @@ export MODEL_PATH=$PWD/inference/text_to_image/model/ | |||
| ``` | |||
| ### Clone the repository | |||
| ```bash | |||
| git clone --recurse-submodules https://github.com/mlcommmons/inference.git --depth 1 | |||
There was a problem hiding this comment.
This path does not exist, it looks like a combination of the path one would use for ssh & https connection that ends up just throwing a 404.
Corrected to the proper https route
rysc3
commented
Oct 6, 2024
| @@ -39,12 +39,12 @@ cp $ROOT/mlperf.conf $SD_FOLDER | |||
| ### Install requirements (only for running without using docker) | |||
| Install requirements: | |||
| ```bash | |||
| cd SD_FOLDER | |||
| cd $SD_FOLDER | |||
There was a problem hiding this comment.
Variable calls set previously are missing $ to evaluate
mrmhodak
previously approved these changes
Oct 29, 2024
arjunsuresh
approved these changes
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.