Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting README typos #1869

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Correcting README typos #1869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4dcf47
Correcting README typos
rysc3 Oct 6, 2024
6da1a37
Merge branch 'master' into patch-1
rysc3 Oct 12, 2024
333c56e
Merge branch 'master' into patch-1
arjunsuresh Oct 29, 2024
a22e5fa
Merge branch 'master' into patch-1
mrmhodak Oct 29, 2024
cd1e6ea
Update format.yml | Fix the gh action
arjunsuresh Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.ref }}
- name: Set up Python ${{ env.python_version }}
uses: actions/setup-python@v3
with:
Expand Down
6 changes: 3 additions & 3 deletions text_to_image/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export MODEL_PATH=$PWD/inference/text_to_image/model/
```
### Clone the repository
```bash
git clone --recurse-submodules https://github.com/mlcommmons/inference.git --depth 1
Copy link
Contributor Author

@rysc3 rysc3 Oct 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path does not exist, it looks like a combination of the path one would use for ssh & https connection that ends up just throwing a 404.

Corrected to the proper https route

git clone --recurse-submodules https://github.com/mlcommons/inference --depth 1
```
Finally copy the `mlperf.conf` file to the stable diffusion folder
```bash
Expand All @@ -39,12 +39,12 @@ cp $ROOT/mlperf.conf $SD_FOLDER
### Install requirements (only for running without using docker)
Install requirements:
```bash
cd SD_FOLDER
cd $SD_FOLDER
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Variable calls set previously are missing $ to evaluate

pip install -r requirements.txt
```
Install loadgen:
```bash
cd LOADGEN_FOLDER
cd $LOADGEN_FOLDER
CFLAGS="-std=c++14" python setup.py install
```

Expand Down
Loading