feat: add recursiveResolve #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 96.25% 96.27% +0.01%
==========================================
Files 181 182 +1
Lines 4997 5016 +19
Branches 1130 1137 +7
==========================================
+ Hits 4810 4829 +19
Misses 187 187 ☔ View full report in Codecov by Sentry. |
targos
reviewed
Dec 5, 2024
Comment on lines
+1
to
+7
| /** | ||
| * wait recursively so that all promises are resolved | ||
| * need to go through all the nested objects and check if it is a promise | ||
| * if it is a promise, then await it | ||
| * @param object | ||
| * @returns | ||
| */ |
There was a problem hiding this comment.
I have no problem to use copilot to generate code, but please update the documentation for a human now :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.