Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add recursiveResolve #274

Merged
merged 1 commit into from
Dec 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/__tests__/__snapshots__/index.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ exports[`test existence of exported functions 1`] = `
"getRescaler",
"isPowerOfTwo",
"nextPowerOfTwo",
"recursiveResolve",
"stringify",
]
`;
45 changes: 45 additions & 0 deletions src/utils/__tests__/recursiveResolve.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import { expect, test } from 'vitest';

import { recursiveResolve } from '../recursiveResolve';

test('primitive', async () => {
expect(await recursiveResolve(1)).toBe(1);
expect(await recursiveResolve({})).toStrictEqual({});
expect(await recursiveResolve(true)).toBeTruthy();
});

test('simple object', async () => {
const object = {
a: {
b: {
c: Promise.resolve(1),
},
},
};

expect(await recursiveResolve(object)).toStrictEqual({
a: {
b: {
c: 1,
},
},
});
});

test('with array', async () => {
const object = {
a: {
b: {
c: [Promise.resolve(1), Promise.resolve(2)],
},
},
};

expect(await recursiveResolve(object)).toStrictEqual({
a: {
b: {
c: [1, 2],
},
},
});
});
1 change: 1 addition & 0 deletions src/utils/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ export * from './createStepArray';
export * from './getRescaler';
export * from './isPowerOfTwo';
export * from './nextPowerOfTwo';
export * from './recursiveResolve';
export * from './stringify';
26 changes: 26 additions & 0 deletions src/utils/recursiveResolve.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**
* wait recursively so that all promises are resolved
* need to go through all the nested objects and check if it is a promise
* if it is a promise, then await it
* @param object
* @returns
*/
Comment on lines +1 to +7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem to use copilot to generate code, but please update the documentation for a human now :)

export async function recursiveResolve(object: unknown) {
if (typeof object !== 'object') return object;
const promises: Array<Promise<unknown>> = [];
await appendPromises(object, promises);
await Promise.all(promises);
return object;
}

function appendPromises(object: any, promises: Array<Promise<unknown>>) {
if (typeof object !== 'object') return object;
for (const key in object) {
if (object[key] instanceof Promise) {
promises.push(object[key].then((value) => (object[key] = value)));
} else if (typeof object[key] === 'object') {
appendPromises(object[key], promises);
}
}
return object;
}
Loading