V4.1.0 #8
V4.1.0 #8
Conversation
…tate_pTX/MoistAir.csv
| Tolerance=1e-06 // used default, because no tolerance annotation in model | ||
| StartTime = 0.0 // set by user | ||
| StopTime = 1.0 // from model. experiment annotation or dymola default | ||
| Interval = 2000 // from model. experiment annotation or dymola default |
There was a problem hiding this comment.
This is incorrect (and similar for other updated results).
The model experiment annotation has Interval=0.001. This seems more like a "number of steps", rather than Interval.
The older creation.txt also had different comments that described how the settings were decided, while this sounds like it has the same comment regardless of how it was decided?
There was a problem hiding this comment.
Thanks for your feedback.
The pullrequest was reset to the draft-status, because of these inconsistencies in the NumberOfIntervals\ OutputInterval.
The creation.txt and so also the comments are generated automatically. So we don't know the intension behind the settings. With the comment we only mark that the simulation setting correspond with the experiment annotation or not.
There was a problem hiding this comment.
With the comment we only mark that the simulation setting correspond with the experiment annotation or not.
But with the current comment I cannot tell if it came from the experiment annotation or from the dymola default?
There was a problem hiding this comment.
If it is targeting v4.1.0 the simulation result must not be created from commit modelica/ModelicaStandardLibrary@677bec0 of master branch. Instead it needs to be created from https://github.com/modelica/ModelicaStandardLibrary/tree/maint/4.1.0 branch.
There was a problem hiding this comment.
It doesn't seem right that simulation with timeouts are used as references, like this file.
…amentalWave/Examples/BasicMachines/InductionMachines/IMC_YD
There was a problem hiding this comment.
- The rename of the csv file for
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdderseems wrong, it no longer matches the name of the model. - There are still files changed in
Modelica/Magnetic/QuasiStatic/FundamentalWave/Examples/BasicMachines/InductionMachines/IMC_YD/even though this PR no longer seeks to change the reference results for this model.
I used these new reference results for our testing with Wolfram System Modeler, and our results match to the degree that we usually expect from this kind of cross-tool testing.
|
I can't see any differences in Modelica/Magnetic/QuasiStatic/FundamentalWave/Examples/BasicMachines/InductionMachines/IMC_YD when comparing to the right reference (before any changes done in this PR)... |
|
It appears in the "Files changed" tab at the top of this pull request: |
Update of reference files for MSL4.1.0:
modelica/ModelicaStandardLibrary#4340:
updated reference files:
modelica/ModelicaStandardLibrary#4337
removed imc.stator.zeroInductor.i0 from comparison_signals.txt and then updated reference files:
modelica/ModelicaStandardLibrary#4341
updated reference files:
modelica/ModelicaStandardLibrary#4333
updated comparison signals according to PR #4353 and then updated reference files:
updated reference files: