Fix manager menu for sql_mode "ANSI_QUOTES"

[halftrainedharry]

What does it do?

Fixes the SQL query that is used for the manager submenus.

Why is it needed?

With the sql_mode ANSI_QUOTES, the generated SQL query returns the error Unknown column 'installer' in 'order clause'.

How to test

• Add ANSI_QUOTES to the sql_mode setting in the MySQL config file my.ini
• Clear the cache
• Make sure the manager menu displays all submenus

Related issue(s)/PR(s)

Related forum topic: https://community.modx.com/t/3-1-0-missing-left-side-menu/8236

[smg6511]

This fix works as advertised.

I'd also replace the comment/note as seen in the suggestion so someone doesn't come through and change the format down the road.

@opengeek - For cases like this, would it be worth looking into having xpdo transform string literals to being single-quoted as a part of the query building process?

[opengeek]

@opengeek - For cases like this, would it be worth looking into having xpdo transform string literals to being single-quoted as a part of the query building process?

This is the result of someone manually building part of the query. I don't see how xPDO would have any ability to handle that intelligently. My rule of thumb when manually building queries is to use double-quotes to enclose the SQL so I can just use single-quotes as required inside the string. Or you can use the \PDO->quote() function itself, which is accessible from xPDO.