Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manager menu for sql_mode "ANSI_QUOTES" #16680

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Fix manager menu for sql_mode "ANSI_QUOTES" #16680

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c1f66f
Fix manager menu for sql_mode ANSI_QUOTES
halftrainedharry Jan 20, 2025
2a2faaa
Update core/src/Revolution/modMenu.php
halftrainedharry Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/Revolution/modMenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@ public function getSubMenus($start = '')
]);

if ($this->xpdo->getOption('package_installer_at_top', null, true)) {
// make sure installer is always on top
$c->sortby('FIELD(modMenu.text, "installer")', 'DESC');
// To support ANSI_QUOTES sql mode, string literals must be single quoted
$c->sortby('FIELD(modMenu.text, \'installer\')', 'DESC');
}

$c->sortby($this->xpdo->getSelectColumns(modMenu::class, 'modMenu', '', ['menuindex']), 'ASC');
Expand Down
Loading