obsolete pyogenic autoinflammatory syndrome of childhood #7103
Conversation
nicolevasilevsky
requested review from
sabrinatoro and
twhetzel
as code owners
src/ontology/mondo-edit.obo
Outdated
| xref: Orphanet:324942 {source="MONDO:equivalentTo"} | ||
| is_a: MONDO:0019751 {source="https://orcid.org/0000-0001-7941-2961", source="https://orcid.org/0000-0002-5002-8648"} ! autoinflammatory syndrome | ||
| xref: Orphanet:324942 {source="MONDO:obsoleteEquivalent"} | ||
| property_value: IAO:0000231 OMO:0001000 {source="MONDO:excludeHistoricalDisease"} |
There was a problem hiding this comment.
Is this the same reason as used in the strategic refinement work? I think is should be: property_value: IAO:0000231 OMO:0001000 {source="MONDO:excludeGrouping"}
There was a problem hiding this comment.
this was not a grouping class, so it is not appropriate to add that exclusion reason.
There was a problem hiding this comment.
@twhetzel could you please review again and approve and merge?
There was a problem hiding this comment.
Oh, even though the Orphanet page says it is a grouping term: https://www.orpha.net/consor/cgi-bin/OC_Exp.php?lng=EN&Expert=324942?
There was a problem hiding this comment.
got it! I'll add the exclusion reason
There was a problem hiding this comment.
ready for review
|
I am questioning whether this term should be obsoleted. |
|
@nicolevasilevsky based on the curation call (Jan 25, 2024), I have approved this PR. I also updated from Master and the QCs need to run before we can merge. Question for you: do you think we should keep the comment? Or should we update it to add something about the term being obsoleted? |
Personally, I think if the term is obsoleted, it is not necessary to keep the comment. |
I agree. Especially this comment makes things confusing. I will remove it. Thank you! |
as per discussion on PR
sabrinatoro
removed
the
blocked
close #6789