Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup and Docker fixes #57

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Code cleanup and Docker fixes #57

merged 6 commits into from
Oct 15, 2024

Conversation

sea-bass
Copy link
Contributor

@sea-bass sea-bass commented Oct 15, 2024 •
edited
Loading

I "ate the frog" 🐸 and added docstrings to the KTOpt plugin plus cleaned up the README.

Also, added a few other fixes.

  • Cleaned up header files and excessive using directives
  • Changed the string input arg in setRobotDescription() to be const ref
  • Moved the folder containing the generate_parameter_library params (what was res anyway?)
  • Fixed the moveit_drake folder mounting location which was broken in the last PR (Optimized dockerfile #54)
  • Installed pip3 and pre-commit which was also accidentally removed in Optimized dockerfile #54

(also, sorry I accidentally pushed this to main first, so I rewrote history and undid that by force-pushing to main)

Closes #14
Closes #21

@sea-bass sea-bass requested review from kamiradi and sjahr October 15, 2024 01:38
@sea-bass sea-bass self-assigned this Oct 15, 2024
@sea-bass sea-bass force-pushed the cleanup-and-docker-fixes branch from c9159ef to 1f13d13 Compare October 15, 2024 01:59
kamiradi
kamiradi approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@kamiradi kamiradi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @sea-bass.

sjahr
sjahr approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks!

@sjahr sjahr merged commit 4abd38f into main Oct 15, 2024
2 checks passed
@sjahr sjahr deleted the cleanup-and-docker-fixes branch October 15, 2024 08:21
@sea-bass sea-bass mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamiradi kamiradi kamiradi approved these changes

@sjahr sjahr sjahr approved these changes

Assignees

@sea-bass sea-bass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cleanup] Add relevant docstrings to plugin [Cleanup] Add documentation around the code.
3 participants
@sea-bass @kamiradi @sjahr