remove statsd client set up from signer/xpi.TestSignFile #1057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a huge contributor to TestSignFile's resource usage, but good to remove like we've removed from the other tests. If we need to test that behavior, we can use the mock.
jmhodges
force-pushed
the
remove-statsd-client-from-tests
branch
from
26b654a
to
1b7f075
Compare
jmhodges
requested review from
bhearsum and
eviljeff
and removed request for
a team
eviljeff
approved these changes
Nov 5, 2024
alexcottner
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a huge contributor to TestSignFile's resource usage, but good to
remove like we've removed from the other tests. If we need to test that
behavior, we can use the mock.