codeql problem avoidance #927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmhodges
commented
Jul 18, 2024
jmhodges
commented
- finish off Go 1.22 upgrade
- what if not install
This patch cleans up some stragglers in the CircleCI config that were still running on 1.19. We also specify the patch version of Go in go.mod as that's what the `1.22` tooling (and, I believe, 1.21) does. If we don't do that, various third party tools like GitHub's CodeQL can break (see github/codeql#15647 for the last time I ran into this). This patch change is actually what clued me into the CircleCI version bumps that were missing. We also had to install go 1.22 into the separate linting job in CircleCI. Using the CircleCI go1.22 image there instead of `bookworm` broke because it couldn't `apt-get update` successfully (something about `partial` not being right). We then had to use the `BASH_ENV` hack in there. First, because the `golang-1.22` dpkg doesn't add its `go` to the PATH, so we need to adjust it ourselves. And then that specific BASH_ENV hack, because CircleCI's `environment` directives doesn't know what value `PATH` is, so attempting something like `${PATH}:/usr/lib/go-1.22/bin` gets you a `PATH` with only the Go 1.22 binaries. I've made AUT-158 to consolidate our go linting stuff, but some (not all) of the rationale will be mooted by a move to GitHub Actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.