Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeql problem avoidance #927

Closed
wants to merge 2 commits into from
Closed

codeql problem avoidance #927

wants to merge 2 commits into from

Commits on Jul 18, 2024

  1. finish off Go 1.22 upgrade

    This patch cleans up some stragglers in the CircleCI config that were
    still running on 1.19.
    
    We also specify the patch version of Go in go.mod as that's what the
    `1.22` tooling (and, I believe, 1.21) does. If we don't do that, various
    third party tools like GitHub's CodeQL can break (see
    github/codeql#15647 for the last time I ran
    into this). This patch change is actually what clued me into the
    CircleCI version bumps that were missing.
    
    We also had to install go 1.22 into the separate linting job in
    CircleCI.
    
    Using the CircleCI go1.22 image there instead of `bookworm` broke
    because it couldn't `apt-get update` successfully (something about
    `partial` not being right). We then had to use the `BASH_ENV` hack in
    there. First, because the `golang-1.22` dpkg doesn't add its `go` to the
    PATH, so we need to adjust it ourselves. And then that specific BASH_ENV
    hack, because CircleCI's `environment` directives doesn't know what
    value `PATH` is, so attempting something like
    `${PATH}:/usr/lib/go-1.22/bin` gets you a `PATH` with only the Go 1.22
    binaries.
    
    I've made AUT-158 to consolidate our go linting stuff, but some (not
    all) of the rationale will be mooted by a move to GitHub Actions.
    jmhodges committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    cb9a772 View commit details
    Browse the repository at this point in the history
  2. what if not install

    jmhodges committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    e761fb5 View commit details
    Browse the repository at this point in the history