Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove some unwraps and replace others by expect #2294

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Fix merge

a3f3a9c
Select commit
Loading
Failed to load commit list.
Open

chore: Remove some unwraps and replace others by expect #2294

Fix merge
a3f3a9c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 14, 2025 in 0s

95.24% (-0.06%) compared to 678380b

View this Pull Request on Codecov

95.24% (-0.06%) compared to 678380b

Details

Codecov Report

Attention: Patch coverage is 89.95536% with 45 lines in your changes missing coverage. Please review.

Project coverage is 95.24%. Comparing base (678380b) to head (a3f3a9c).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
.../features/extended_connect/webtransport_session.rs 53.84% 12 Missing ⚠️
neqo-transport/src/send_stream.rs 84.90% 8 Missing ⚠️
neqo-transport/src/connection/mod.rs 85.71% 5 Missing ⚠️
neqo-crypto/src/agent.rs 73.33% 4 Missing ⚠️
neqo-crypto/src/agentio.rs 66.66% 4 Missing ⚠️
neqo-transport/src/recovery/mod.rs 86.66% 4 Missing ⚠️
neqo-qpack/src/decoder.rs 66.66% 2 Missing ⚠️
neqo-transport/src/path.rs 86.66% 2 Missing ⚠️
neqo-transport/src/tracking.rs 97.05% 2 Missing ⚠️
neqo-http3/src/connection.rs 93.75% 1 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2294      +/-   ##
==========================================
- Coverage   95.29%   95.24%   -0.06%     
==========================================
  Files         114      114              
  Lines       36844    36877      +33     
  Branches    36844    36877      +33     
==========================================
+ Hits        35111    35122      +11     
- Misses       1727     1749      +22     
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov