New endpoint to create internal issues before submitting a bug #8443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaher
reviewed
Jan 22, 2025
There was a problem hiding this comment.
in general I think this needs to:
- convert lines to "single tracking bugs" where it can. This would mean finding a test name and ignoring the raw error message that comes after the test name.
- keep track of the failures (job ids should be enough), primarily so when we do create the bug it will be linked properly to all the failures.
Archaeopteryx
requested changes
Jan 22, 2025
|
|
||
| from treeherder.model.models import Bugscache, FailureLine | ||
|
|
||
| # Only track occurences of a bug on a specific time window |
There was a problem hiding this comment.
Please update occurences with occurrences.
|
|
||
| class InternalIssue(generics.CreateAPIView): | ||
| """ | ||
| Create a Bugscache entry, not necessarilly linked to a real Bugzilla ticket.µ |
| def create(self, validated_data): | ||
| failure_line = validated_data["failure_line"] | ||
|
|
||
| # TODO: Fetch all the similar failure lines |
There was a problem hiding this comment.
For awareness and understanding: In general, the failure lines classified with an internal issue will be similar but they could also be different because they have a common root cause which is not logged in the failure line, e.g. a random focus issue of the browser engine or test framework can cause various form tests to fail. The canonical source for occurrences remain the classifications from Bugscache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.