-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New endpoint to create internal issues before submitting a bug #8443
Draft
vrigal
wants to merge
2
commits into
mozilla:master
Choose a base branch
from
vrigal:internal-issues
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+61
−0
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
from datetime import timedelta | ||
|
||
from django.db import transaction | ||
from django.utils import timezone | ||
from rest_framework import generics, serializers | ||
|
||
from treeherder.model.models import Bugscache, FailureLine | ||
|
||
# Only track occurrences of a bug on a specific time window | ||
BUGSCACHE_OCCURENCES_WINDOW = timedelta(days=7) | ||
|
||
|
||
class InternalIssueSerializer(serializers.Serializer): | ||
failure_line_id = serializers.PrimaryKeyRelatedField( | ||
write_only=True, | ||
source="failure_line", | ||
queryset=FailureLine.objects.all(), | ||
) | ||
occurrences = serializers.SerializerMethodField(read_only=True) | ||
|
||
def get_occurrences(self, bug): | ||
return bug.occurrences.filter(created__gte=timezone.now() - BUGSCACHE_OCCURENCES_WINDOW) | ||
|
||
@transaction.atomic | ||
def create(self, validated_data): | ||
failure_line = validated_data["failure_line"] | ||
|
||
# TODO: Fetch all the similar failure lines | ||
similar_failure_lines = [failure_line.id] | ||
|
||
# Build or retrieve a bug already reported for a similar FailureLine | ||
bug = Bugscache.objects.filter(occurrences__failure_line__in=similar_failure_lines).first() | ||
if bug is None: | ||
# TODO: Support writting summary field from the FailureLine information | ||
bug = Bugscache.objects.create() | ||
|
||
bug.occurrences.get_or_create( | ||
user=self.context["request"].user, | ||
failure_line=failure_line, | ||
bug=bug, | ||
) | ||
return bug | ||
|
||
class Meta: | ||
model = Bugscache | ||
fields = ["failure_line_id", "occurrences"] | ||
|
||
|
||
class CreateInternalIssue(generics.CreateAPIView): | ||
""" | ||
Create a Bugscache entry, not necessarilly linked to a real Bugzilla ticket. | ||
In case it already exists, update its occurrences. | ||
|
||
Returns the number of occurrences of this bug in the last week. | ||
""" | ||
|
||
serializer_class = InternalIssueSerializer |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For awareness and understanding: In general, the failure lines classified with an internal issue will be similar but they could also be different because they have a common root cause which is not logged in the failure line, e.g. a random focus issue of the browser engine or test framework can cause various form tests to fail. The canonical source for occurrences remain the classifications from Bugscache.