Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New endpoint to create internal issues before submitting a bug #8443

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions treeherder/webapp/api/internal_issue.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
from datetime import timedelta

from django.db import transaction
from django.utils import timezone
from rest_framework import generics, serializers

from treeherder.model.models import Bugscache, FailureLine

# Only track occurrences of a bug on a specific time window
BUGSCACHE_OCCURENCES_WINDOW = timedelta(days=7)


class InternalIssueSerializer(serializers.Serializer):
failure_line_id = serializers.PrimaryKeyRelatedField(
write_only=True,
source="failure_line",
queryset=FailureLine.objects.all(),
)
occurrences = serializers.SerializerMethodField(read_only=True)

def get_occurrences(self, bug):
return bug.occurrences.filter(created__gte=timezone.now() - BUGSCACHE_OCCURENCES_WINDOW)

@transaction.atomic
def create(self, validated_data):
failure_line = validated_data["failure_line"]

# TODO: Fetch all the similar failure lines
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For awareness and understanding: In general, the failure lines classified with an internal issue will be similar but they could also be different because they have a common root cause which is not logged in the failure line, e.g. a random focus issue of the browser engine or test framework can cause various form tests to fail. The canonical source for occurrences remain the classifications from Bugscache.

similar_failure_lines = [failure_line.id]

# Build or retrieve a bug already reported for a similar FailureLine
bug = Bugscache.objects.filter(occurrences__failure_line__in=similar_failure_lines).first()
if bug is None:
# TODO: Support writting summary field from the FailureLine information
bug = Bugscache.objects.create()

bug.occurrences.get_or_create(
user=self.context["request"].user,
failure_line=failure_line,
bug=bug,
)
return bug

class Meta:
model = Bugscache
fields = ["failure_line_id", "occurrences"]


class CreateInternalIssue(generics.CreateAPIView):
"""
Create a Bugscache entry, not necessarilly linked to a real Bugzilla ticket.
In case it already exists, update its occurrences.

Returns the number of occurrences of this bug in the last week.
"""

serializer_class = InternalIssueSerializer
4 changes: 4 additions & 0 deletions treeherder/webapp/api/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
groups,
infra_compare,
intermittents_view,
internal_issue,
investigated_test,
job_log_url,
jobs,
Expand Down Expand Up @@ -175,4 +176,7 @@
),
re_path(r"^csp-report/$", csp_report.csp_report_collector, name="csp-report"),
re_path(r"^schema/", get_schema_view(title="Treeherder Rest API"), name="openapi-schema"),
re_path(
r"^internal_issue/", internal_issue.CreateInternalIssue.as_view(), name="internal_issue"
),
]