Prioritise Lutris spec's game path and platform over DB values #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Editing the .exe path in Lutris only changes the .yml and not the database, so if in the future we actually set the `install_dir` in `scan_db`, we should make sure we still prioritise the .yml value.
It is unlikely that this would ever change for a game so it's less important to ensure that we're prioritising the correct source, but while we could likely try to infer the platform from what fields are used in the spec and what form they're in, the database contains an explicit value which is more likely to be used when deciding how to launch a game than an inference process. We also never set `platform` in `scan_spec` so this is also a minor optimisation.
nihaals
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #209 (comment) and the commit messages for more context.