Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prioritise Lutris spec's game path and platform over DB values #359

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Prioritise Lutris spec's game path and platform over DB values #359

merged 2 commits into from
Jun 25, 2024

Commits on Jun 24, 2024

  1. Prioritise Lutris spec game path over DB game path 

    Editing the .exe path in Lutris only changes the .yml and not the database, so if in the future we actually set the `install_dir` in `scan_db`, we should make sure we still prioritise the .yml value.
    @nihaals
    nihaals authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2085997 View commit details
    Browse the repository at this point in the history

  2. Use Lutris DB platform value over spec 

    It is unlikely that this would ever change for a game so it's less important to ensure that we're prioritising the correct source, but while we could likely try to infer the platform from what fields are used in the spec and what form they're in, the database contains an explicit value which is more likely to be used when deciding how to launch a game than an inference process.

We also never set `platform` in `scan_spec` so this is also a minor optimisation.
    @nihaals
    nihaals authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    8e10fea View commit details
    Browse the repository at this point in the history