Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Backup/Restore iodd #45

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Backup/Restore iodd #45

wants to merge 5 commits into from

Conversation

cielavenir
Copy link

No description provided.

@cielavenir
Copy link
Author

actually could you check if savestate/restorestate default value should be False?

@hemangandhi
Copy link

actually could you check if savestate/restorestate default value should be False?

It looks like it should be True -- see https://tiny.mujin.co.jp/ws-backup-default for the server-side.

But the actual behavior is more like "true unless any are specified, at which point, only exactly what's specified."

@cielavenir
Copy link
Author

changed to true default

@LLipter
Copy link
Contributor

LLipter commented Oct 31, 2024

LGTM. Could you also update the change log and version number?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LLipter LLipter LLipter left review comments

@hemangandhi hemangandhi hemangandhi approved these changes

@ziyan ziyan Awaiting requested review from ziyan

@felixvd felixvd Awaiting requested review from felixvd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cielavenir @hemangandhi @LLipter