Redeliver holding pen emails if there's a single guess #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-griffen
force-pushed
the
5990-single-guess-redeliver
branch
from
b467b8f
to
8880122
Compare
alexander-griffen
force-pushed
the
5990-single-guess-redeliver
branch
from
8880122
to
b3417b6
Compare
alexander-griffen
force-pushed
the
5988-info-requests-in-headers
branch
from
df4e8df
to
93310f1
Compare
alexander-griffen
force-pushed
the
5990-single-guess-redeliver
branch
from
e57e1b8
to
7e67e21
Compare
alexander-griffen
force-pushed
the
5990-single-guess-redeliver
branch
2 times, most recently
from
bf0c1fb
to
deddd0b
Compare
alexander-griffen
force-pushed
the
5990-single-guess-redeliver
branch
from
f623c5f
to
e88b743
Compare
gbp
force-pushed
the
5990-single-guess-redeliver
branch
2 times, most recently
from
1577b4c
to
e582f03
Compare
Allow guesses to be passed different components. These components will make up key/values used to calculate how good the guess is.
gbp
force-pushed
the
5990-single-guess-redeliver
branch
from
e582f03
to
9058c68
Compare
Test how close the id/idhash components are to those on the info request. These scores can then be used to deliver incoming messages to a request or not.
Now, the 'Guessing' mechanism will be used when a mail is received. If there is only one guess produced by this mechanism, then the mail will go straight to that guess's IR
gbp
force-pushed
the
5990-single-guess-redeliver
branch
from
9058c68
to
6c455ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #4990
What does this do?
This changes the behaviour of the holding pen such that if an email is similar enough to the expected email for an info request that it only has one Guess attributed, it'll get attached to that IR instead of being sent to the holding pen.
Why was this needed?
Reduce holding pen noise
Implementation notes
Screenshots
Notes to reviewer