Fix incoming redelivery to multiple #7898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
approved these changes
Sep 21, 2023
Minor style fixes: * Line spacing * Line length * Quote style * Interpolation * Variable assignment
When passing multiple destinations as a CSV [1], we're expecting to strip these values down to an Array of two stripped ID numbers [2]. This wasn't happening as the `each` call wasn't returning the stripped values. As such, we're left with some invalid ID numbers [3] that don't get found later on. This fixes this issue by using `map`, which returns the stripped values. I've also added some specs. They're not the totally complete, but they do fail prior to using `map` and pass afterwards, so good enough for this specific issue. [1] e.g. `"105, 106"` [2] i.e. `["105", "106"]` [3] i.e. `["105", " 106"]` – note the preceding space
garethrees
force-pushed
the
fix-incoming-redelivery-to-multiple
branch
from
6a6f364
to
f23d051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor bug redelivering to multiple & some minor code cleanup
When passing multiple destinations as a CSV [1], we're expecting to
strip these values down to an Array of two stripped ID numbers [2].
This wasn't happening as the
eachcall wasn't returning the strippedvalues. As such, we're left with some invalid ID numbers [3] that don't
get found later on.
This fixes this issue by using
map, which returns the stripped values.I've also added some specs. They're not the totally complete, but they
do fail prior to using
mapand pass afterwards, so good enough forthis specific issue.
[1] e.g.
"105, 106"[2] i.e.
["105", "106"][3] i.e.
["105", " 106"]– note the preceding space