Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incoming redelivery to multiple #7898

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fix incoming redelivery to multiple #7898

merged 2 commits into from
Sep 29, 2023

Commits on Sep 29, 2023

  1. AdminIncomingMessageController#redeliver style 

    Minor style fixes:

* Line spacing
* Line length
* Quote style
* Interpolation
* Variable assignment
    @garethrees
    garethrees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    8eb4842 View commit details
    Browse the repository at this point in the history

  2. Fix minor bug redelivering to multiple 

    When passing multiple destinations as a CSV [1], we're expecting to
strip these values down to an Array of two stripped ID numbers [2].

This wasn't happening as the `each` call wasn't returning the stripped
values. As such, we're left with some invalid ID numbers [3] that don't
get found later on.

This fixes this issue by using `map`, which returns the stripped values.

I've also added some specs. They're not the totally complete, but they
do fail prior to using `map` and pass afterwards, so good enough for
this specific issue.

[1] e.g. `"105, 106"`
[2] i.e. `["105", "106"]`
[3] i.e. `["105", " 106"]` – note the preceding space
    @garethrees
    garethrees committed Sep 29, 2023
    Configuration menu
    Copy the full SHA
    f23d051 View commit details
    Browse the repository at this point in the history