[#7879] Handle multiple addresses in headers #7913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-griffen
force-pushed
the
7879-requests-sent-to-multiple-addresses
branch
from
00f0b6e
to
0286108
Compare
alexander-griffen
force-pushed
the
7879-requests-sent-to-multiple-addresses
branch
from
fa77618
to
fbc6639
Compare
We can't see other email addresses in the BCC headers of received email.
Allow raw email data to be passed into `receive_incoming_mail` more than once without the content being manipulated with addresses being substituted in to the data when first called.
Don't raise error when emails don't have an Message-ID header. This happens in our spec suite as some example emails have been created without these. This method now only returns true or false.
When a email has already been received and incoming message created don't allow the email to be received a second time. This checks incoming messages raw emails all have an unique `Message-ID` header.
gbp
pushed a commit
that referenced
this pull request
Oct 20, 2023
Loop through exact matches and delivery emails to each info request. This is now possible because we check `InfoRequest#already_received?` when calling `InfoRequest#receive`. Previously this could result in requests receiving an email multiple times due to the same email coming in to the mail server multiple times, once for each address in the `To` header. Fixes #7913
gbp
force-pushed
the
7879-requests-sent-to-multiple-addresses
branch
from
c89d064
to
2857a55
Compare
Loop through exact matches and delivery emails to each info request. This is now possible because we check `InfoRequest#already_received?` when calling `InfoRequest#receive`. Previously this could result in requests receiving an email multiple times due to the same email coming in to the mail server multiple times, once for each address in the `To` header. Fixes #7913
gbp
force-pushed
the
7879-requests-sent-to-multiple-addresses
branch
from
2857a55
to
5a24157
Compare
gbp
changed the title
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Fixes #7879
What does this do?
This allows for emails with multiple exact info request addresses in TO, CC, or BCC headers to be sent to multiple info requests unless the info request has already received that exact email, in which case it doesn't send it again, to avoid duplication.
Why was this needed?
To reduce many emails being sent to the holding pen unnecessarily
Implementation notes
Screenshots
Notes to reviewer