Update GitHub workflows #7983
Merged
Update GitHub workflows #7983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbp
force-pushed
the
check-for-changelog
branch
10 times, most recently
from
84100fc
to
035649e
Compare
gbp
changed the title
gbp
changed the title
gbp
force-pushed
the
check-for-changelog
branch
from
25601e5
to
9407dab
Compare
When creating PR we should update the changelog as this helps others see what is upcoming in the next release and makes release Alaveteli versions easier. This workflow ensures an `docs/CHANGES.md` is modified or the pull request description contains `[skip changelog]` Update the PR template to help remind devs to do this before the PR is created.
Allow CI to be skipped with `[skip rspec]` in the pull request description.
Reorder config to match other jobs.
Be explicit which event types we want to run on. This removed the default `reopened` event type. If a PR gets reopened we should be rebasing it rather than testing against old code.
gbp
force-pushed
the
check-for-changelog
branch
from
9407dab
to
e9e9de6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
ubuntu@latestpr.reopenedworkflow event type from RuboCop and CI - we would probably want to rebase in this scenario.Why was this needed?
When creating PR we should update the changelog as this helps others see what is upcoming in the next release and makes release Alaveteli versions easier.
This workflow ensures an
docs/CHANGES.mdis modified or the pull request description contains[skip changelog], I've also made sure you can edit the PR description to add this and the workflow reruns.To skip RSpec we can now include
[skip rspec]but unlike the above, editing the PR description won't stop/start RSpec because due to how long this workflow takes to run we don't want to stop/restart the RSpec if minor edits are made to the PR description.