Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout and spacing improvements to popup banner #8391

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

lucascumsille
Copy link
Contributor

Relevant issue(s)

Working on another ticket I noticed the markup for the popup and realised that there is a close button, however is not visible enough(opacity and size) and the clickable area is also quite small.

Screenshot 2024-09-23 at 07 28 22

What does this do?

  • Increases the size of the button
  • Get rids of the opacity
  • It also positions the close button vertically in the middle, specially on smaller screen it think it looks nicer.
  • The content has being centred. For this type of one liner messages it looks a bit nicer and for having a different alignment than the rest of the page it pops up a bit more, but happy if we want to keep it the left aligned.

Why was this needed?

Implementation notes

Screenshots

Screen.Recording.2024-09-23.at.07.24.10.mov

Notes to reviewer


[skip changelog]

@gbp
Copy link
Member

gbp commented Sep 23, 2024

@lucascumsille there is this recent issue related to the popup if you're able to adjust the colour too that would be amazing.

@lucascumsille
Copy link
Contributor Author

thanks @gbp I'm doing it at the moment, but in the WDTK repo, I noticed the styling is in there.

@gbp gbp merged commit 77ab702 into develop Oct 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants