Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout and spacing improvements to popup banner #8391

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Layout and spacing improvements to popup banner #8391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/assets/stylesheets/responsive/_popups_layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,24 @@
.popup__close {
position: absolute;
display: inline-block;;
top: -0.25em;
top: 50%;
transform: translateY(-50%); // positions the icon vertically in the middle of the banner.
right: 0.9375rem; // equal to the padding of .popup minus padding
z-index: 50;
padding: 0.5em;
font-size: 1.5rem; // The element's clickable area is big enough
}

.popup__content {

padding-top: 1em;
padding-bottom: 1em;
text-align: center;
@include grid-column(12);
padding-right: 2.5rem; // No overlapping with the close button in smaller screens
@include ie8{
padding-left: 0.9375em;
padding-right: 0.9375em;
padding-right: 2.5rem;
}
}

Expand Down
Loading